feat(inputs.vsphere): Flag for more lenient behavior when connect fails on startup #12828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
|
The merge history looks a bit stupid, but I've checked it and it's fine. Just an artifact of how I brought the changes I made earlier today into this branch. Yes, I should have rebased instead... :) |
powersj
added
the
ready for final review
srebhan
reviewed
Mar 10, 2023
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
I'm fine with your suggested changed and I've committed them. |
srebhan
changed the title
srebhan
added
area/vsphere
plugin/input
yjiabj123
reviewed
Mar 30, 2023
| ## Specifies plugin behavior regarding disconnected servers | ||
| ## Available choices : | ||
| ## - error: telegraf will return an error on startup if one the servers is unreachable | ||
| ## - skip: telegraf will skip unreachable servers on both startup and gather |
There was a problem hiding this comment.
Might be 'ignore' instead of 'skip'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10523
Added the server_disconnected_behavior flag mimicking the behavior of the MongoDB-plugin. A value of "error" (default) exits telegraf if the connection to vCenter failed on startup. A value of "ignore" prints a warning and continues to try to connect every collection cycle.