fix(inputs.temp): ignore warnings returned by gopsutil #12842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
powersj
added
the
ready for final review
The temperature sensor reading can return warnings as an error. Previously we ignored these, but they were removed from gopsutil. The warning was returned to gopsutil and we should continue to ignore warnings and only fail on a true error. fixes: influxdata#12841
|
Hmm looking at gopsutil some more it looks like it was only added-back for linux hosts: https://github.com/shirou/gopsutil/pull/1379/files so probably not getting this in for v1.26.0 today, and will need to work with upstream |
powersj
removed
the
ready for final review
|
closing until I get upstream fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The temperature sensor reading can return warnings as an error. Previously we ignored these, but they were removed from gopsutil. The warning was returned to gopsutil and we should continue to ignore warnings and only fail on a true error.
fixes: #12841