Made the apache input’s urls parameter optional by using a reasonable default user input #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,7 @@ type Apache struct { | |||
| } | |||
|
|
|||
| var sampleConfig = ` | |||
| ## An array of Apache status URI to gather stats. | |||
| ## An array of Apache status URI to gather stats. Default is "http://localhost/server-status?auto". | |||
There was a problem hiding this comment.
please limit lines to 80 chars
… default for most users
|
Made the change and rebased it, please review @sparrc |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Since most users will run this plugin on the destination host, the default http://localhost/server-status?auto is just fine and will be the default if urls is not defined simplifying the telegraf configuration for those users. They just need to add [[inputs.apache]] to be done.