Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs.opentelemetry): group metrics by age and timestamp #13292

Merged
merged 3 commits into from
Jul 14, 2023
Merged

fix(outputs.opentelemetry): group metrics by age and timestamp #13292

merged 3 commits into from
Jul 14, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented May 19, 2023

This will group open telemetry metrics from oldest to newest and group them by timestamp. This ensures they are kept in order in the event that old and new metrics become grouped up after buffering metrics.

fixes: #13233

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels May 19, 2023
@powersj powersj mentioned this pull request May 19, 2023
Closed
@powersj powersj self-assigned this Jun 2, 2023
@powersj powersj closed this Jul 11, 2023
@powersj powersj reopened this Jul 11, 2023
@influxdata influxdata deleted a comment from telegraf-tiger bot Jul 11, 2023
@powersj powersj closed this Jul 11, 2023
@powersj powersj reopened this Jul 11, 2023
@powersj powersj marked this pull request as ready for review July 13, 2023 18:56
@powersj powersj assigned srebhan and unassigned powersj Jul 13, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 13, 2023
srebhan
srebhan reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj for the fix. I have one suggestion and one request for clarification on why sorted() is required...

plugins/outputs/opentelemetry/opentelemetry.go Outdated Show resolved Hide resolved
plugins/outputs/opentelemetry/opentelemetry.go Outdated Show resolved Hide resolved
@powersj
fix(outputs.opentelemetry): group metrics by age and timestamp
e4ad08c 
This will group open telemetry metrics from oldest to newest and group
them by timestamp. This ensures they are kept in order in the event that
old and new metrics become grouped up after buffering metrics.

fixes: influxdata#13233
@powersj
remove unecessary sorted func
2b95a25
@powersj
Copy link
Contributor Author

powersj commented Jul 14, 2023

@srebhan removed function and updated log message, thanks!

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit 6377f69 into influxdata:master Jul 14, 2023
25 of 26 checks passed
@powersj powersj deleted the fix/13233 branch July 14, 2023 15:25
@github-actions github-actions bot added this to the v1.27.3 milestone Jul 14, 2023
powersj added a commit that referenced this pull request Jul 31, 2023
@powersj
fix(outputs.opentelemetry): group metrics by age and timestamp (#13292)
7069f5b 
(cherry picked from commit 6377f69)
@powersj powersj restored the fix/13233 branch March 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.3
Development

Successfully merging this pull request may close these issues.

Order metrics by timestamp for outputs.opentelemetry
2 participants
@powersj @srebhan