-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(custom_builder): Correctly handle serializers and parsers #13446
fix(custom_builder): Correctly handle serializers and parsers #13446
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Hmm something is up with the [[inputs.exec]]
commands = ["echo metric,tag=1 value=42"]
data_format = "json"
[[outputs.file]]
data_format = "influx_upstream" |
@powersj will take a look... |
@powersj I do not see any |
facepalm - it's a parser not a serializer.... let me give this one final look over |
(cherry picked from commit a2125f0)
resolves #13441
This PR fixes the handling of serializers and solves #13441. During debugging I also noticed that, in case of multiple plugin instances, the default parser and serializer is not correctly selected if one of the other plugins already defines a
data_format
. Furthermore,processors.execd
requires a special treatment as it requires both a serializer and parser of the same type with the defineddata_format
. To handle those cases correctly the internal code had to be changed quite a bit but is much cleaner and much more robust IMO.