Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus): Add per-metric configuration style #13507

Merged
merged 7 commits into from
Jun 30, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jun 27, 2023

This PR adds a per-metric configuration style to the modbus plugin. This style provides a metric-centric view on the definition by jotting down the metrics to output and map the fields to modbus registers. This way it is easy to define desired fields and tags to output. Behind the scenes, the plugin will then create requests for the devices and referenced registers. The plugin also allows to optimize those requests if desired.

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 27, 2023
@srebhan srebhan mentioned this pull request Jun 27, 2023
9 tasks
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 27, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@powersj powersj merged commit 96b9845 into influxdata:master Jun 30, 2023
24 checks passed
powersj pushed a commit to powersj/telegraf that referenced this pull request Jul 5, 2023
@srebhan srebhan added this to the v1.28.0 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants