Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs.sumologic): Unwrap serializer for type check #13522

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix(outputs.sumologic): Unwrap serializer for type check #13522

merged 1 commit into from
Jul 4, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jun 30, 2023

resolves #13520

With the serializer migration the passed-on serializers are now of type models.RunningSerializer and need unwrapping for type-checking. Do this for the SumoLogic output and also simplify the code.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jun 30, 2023
@srebhan srebhan mentioned this pull request Jun 30, 2023
Closed
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 30, 2023
@srebhan
Copy link
Contributor Author

srebhan commented Jun 30, 2023

@powersj ready for review but I'd like to wait for the confirmation from the reporter that this fixed the issue...

@powersj powersj assigned srebhan and unassigned powersj Jun 30, 2023
@srebhan srebhan merged commit 0291aaf into influxdata:master Jul 4, 2023
24 checks passed
@srebhan srebhan deleted the sumologic_issue_13520 branch July 4, 2023 19:37
powersj pushed a commit to powersj/telegraf that referenced this pull request Jul 5, 2023
@srebhan @powersj
fix(outputs.sumologic): Unwrap serializer for type check (influxdata#…
0f99f51 
…13522)
powersj pushed a commit that referenced this pull request Jul 10, 2023
@srebhan @powersj
fix(outputs.sumologic): Unwrap serializer for type check (#13522)
cfb9d0e 
(cherry picked from commit 0291aaf)
@srebhan srebhan added this to the v1.27.2 milestone Jul 10, 2023
@p-linnane p-linnane mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins plugin/serializer ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.2
Development

Successfully merging this pull request may close these issues.

Sending Metrics to SumoLogic Stopped Working in v1.27
2 participants
@srebhan @powersj