Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.graphite): Rework connection handling #13527

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jun 30, 2023

resolves #13483
resolves #13491

The graphite connection handling was complex and error prone as the connection information was split among three three struct members (Servers, conns and failedServers). This PR centralizes the information into a struct shared by all functions. This way, we can always know which servers are available, mark them unavailable and reconnect correctly.

@telegraf-tiger telegraf-tiger bot added area/graphite fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jun 30, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 30, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - hope this helps folks!

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 3, 2023

@srebhan
Copy link
Contributor Author

srebhan commented Jul 5, 2023

Both issues are reported to be resolved with this PR. So I think we are good to go.

@srebhan srebhan merged commit 533ede7 into influxdata:master Jul 5, 2023
25 checks passed
@srebhan srebhan deleted the graphite_issue_13483 branch July 5, 2023 19:16
powersj pushed a commit that referenced this pull request Jul 10, 2023
@srebhan srebhan added this to the v1.27.2 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphite fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
2 participants