-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(outputs.graphite): Rework connection handling #13527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - hope this helps folks!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Both issues are reported to be resolved with this PR. So I think we are good to go. |
(cherry picked from commit 533ede7)
resolves #13483
resolves #13491
The graphite connection handling was complex and error prone as the connection information was split among three three struct members (
Servers
,conns
andfailedServers
). This PR centralizes the information into a struct shared by all functions. This way, we can always know which servers are available, mark them unavailable and reconnect correctly.