Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Setup logger for secret-stores #13671

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jul 25, 2023

Currently, the logger of secret-stores is not set, leading to situations where any logging will result in a panic. This PR sets-up the loggers correctly (if instantiated) and thus fixing those potential issues.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jul 25, 2023
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 25, 2023
@powersj powersj merged commit 63ed4b5 into influxdata:master Jul 25, 2023
25 of 26 checks passed
@github-actions github-actions bot added this to the v1.27.3 milestone Jul 25, 2023
powersj pushed a commit that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration fix pr to fix corresponding bug plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants