Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.execd): Add option for batch format #13673

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

gazpachoking
Copy link
Contributor

Required for all PRs

refs #13654

Adds use_batch_format option to execd output plugin. This allows user to specify that the serializer should use the batch format when serializing metrics. Most useful for json serializer, and upcoming template serializer, as they can create completely different payloads when in batch mode.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to put up a PR! couple questions below

plugins/outputs/execd/README.md Outdated Show resolved Hide resolved
plugins/outputs/execd/README.md Outdated Show resolved Hide resolved
@powersj powersj self-assigned this Jul 26, 2023
@powersj powersj added waiting for response waiting for response from contributor feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jul 26, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @gazpachoking!

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I'll merge once test re-run passes

@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 087a668 into influxdata:master Jul 26, 2023
25 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin waiting for response waiting for response from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants