-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.nvidia_smi): Support newer data schema versions #13678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - can you see the comment about the module power readings? Since we know it is also new it seems worth adding now as well.
ea00c02
to
978d762
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - like the parse in location usage
resolves #13653
Issue #13653 shows an example of a v12 data schema as output by the Nvidia SMI tool. So far we successfully handle v10 and v11 versions of the scheme.
This PR paves the way to easily add new versions of the data schema and implements the v12 scheme.