Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.nvidia_smi): Support newer data schema versions #13678

Merged
merged 12 commits into from
Jul 28, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jul 26, 2023

resolves #13653

Issue #13653 shows an example of a v12 data schema as output by the Nvidia SMI tool. So far we successfully handle v10 and v11 versions of the scheme.

This PR paves the way to easily add new versions of the data schema and implements the v12 scheme.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 26, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 26, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - can you see the comment about the module power readings? Since we know it is also new it seems worth adding now as well.

@srebhan srebhan requested a review from powersj July 27, 2023 11:16
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - like the parse in location usage

@powersj powersj assigned srebhan and unassigned powersj Jul 28, 2023
@powersj powersj merged commit f5afcc1 into influxdata:master Jul 28, 2023
26 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[input.nvidia_smi] Broken power monitoring due to XML schema change
2 participants