Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.opcua): Register node IDs again on reconnect #13682

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jul 27, 2023

resolves #13594

Issue #13594 suggests that the node IDs of a OPCUA connections are not longer valid if the server was restarted. As we cannot decide if the connection was lost due to client or server side, we re-initialize the node IDs on reconnect to be on the safe side.

@telegraf-tiger telegraf-tiger bot added area/opcua fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 27, 2023
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - going to re-assign you while you wait for community confirmation

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 31, 2023
@srebhan srebhan merged commit 424283f into influxdata:master Aug 7, 2023
26 checks passed
@srebhan srebhan deleted the opcua_issue_13594 branch August 7, 2023 20:48
@github-actions github-actions bot added this to the v1.27.4 milestone Aug 7, 2023
powersj pushed a commit that referenced this pull request Aug 21, 2023
@R290 R290 mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/opcua fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPC-UA plugin does not find all nodes after restarting the OPC-UA server
2 participants