Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serializers.nowmetric): Add option for JSONv2 format #13722

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 3, 2023

The nowmetric serializer by default produces metrics in the Operational
Intelligence format. This adds a format object, which can be set to
jsonv2 to produce metrics compatible with the JSONv2 endpoint.

The primary difference is in the JSON format. The JSONv2 endpoint is
based around an object, while the previous OI format is based around a
list of metrics.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/serializer labels Aug 3, 2023
The nowmetric serializer by default produces metrics in the Operational
Intelligence format. This adds a format object, which can be set to
jsonv2 to produce metrics compatable with the JSONv2 endpoint.

The primary difference is in the JSON format. The JSONv2 endpoint is
based around an object, while the previous OI format is based around a
list of metrics.
@powersj powersj changed the title feat(serializers.nowmetric): Add option to return single JSON object feat(serializers.nowmetric): Add option for JSONv2 format Aug 4, 2023
@powersj powersj marked this pull request as ready for review August 8, 2023 18:14
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 8, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments @powersj...

plugins/serializers/nowmetric/README.md Outdated Show resolved Hide resolved
plugins/serializers/nowmetric/nowmetric.go Outdated Show resolved Hide resolved
powersj and others added 2 commits August 8, 2023 12:18
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srebhan srebhan assigned powersj and unassigned srebhan Aug 8, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 8, 2023

@srebhan srebhan assigned srebhan and unassigned powersj Aug 8, 2023
@srebhan srebhan merged commit 93bf2be into influxdata:master Aug 8, 2023
23 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Aug 8, 2023
powersj added a commit that referenced this pull request Aug 21, 2023
@powersj powersj modified the milestones: v1.28.0, v1.27.4 Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/serializer ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants