Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.redis): support of redis 6.2 ERRORSTATS #13723

Merged
merged 3 commits into from
Aug 8, 2023
Merged

feat(inputs.redis): support of redis 6.2 ERRORSTATS #13723

merged 3 commits into from
Aug 8, 2023

Conversation

kell0gg
Copy link
Contributor

@kell0gg kell0gg commented Aug 4, 2023

Required for all PRs

resolves #13717

srebhan
srebhan reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @kell0gg! Some small comments...

plugins/inputs/redis/README.md Outdated Show resolved Hide resolved
plugins/inputs/redis/README.md Show resolved Hide resolved
plugins/inputs/redis/redis.go Outdated Show resolved Hide resolved
@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/redis plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 7, 2023
@srebhan srebhan self-assigned this Aug 7, 2023
srebhan
srebhan approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the nice PR @kell0gg!

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 8, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 8, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Aug 8, 2023
@powersj powersj merged commit 3fe151b into influxdata:master Aug 8, 2023
22 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
area/redis feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

Support of Redis 6.2 ERRORSTATS
3 participants
@kell0gg @powersj @srebhan