Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs): Add new S7comm plugin #13731

Merged
merged 13 commits into from
Aug 9, 2023
Merged

feat(inputs): Add new S7comm plugin #13731

merged 13 commits into from
Aug 9, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Aug 7, 2023

This new plugin allows to read metrics from Siemens PLCs using the S7 protocol.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 7, 2023
@srebhan srebhan added new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 7, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 9, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and an amazing amount of work in short time, thank you for jumping on this! Few questions throughout. Could just be education me ;)

plugins/inputs/s7comm/type_conversions.go Outdated Show resolved Hide resolved
plugins/inputs/s7comm/s7comm.go Outdated Show resolved Hide resolved
plugins/inputs/s7comm/s7comm.go Outdated Show resolved Hide resolved
plugins/inputs/s7comm/README.md Show resolved Hide resolved
@srebhan srebhan requested a review from powersj August 9, 2023 19:24
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 9, 2023

@srebhan srebhan merged commit 8b032b7 into influxdata:master Aug 9, 2023
23 checks passed
@srebhan srebhan deleted the s7comm branch August 9, 2023 19:56
@github-actions github-actions bot added this to the v1.28.0 milestone Aug 9, 2023
@St3f1n
Copy link

St3f1n commented Nov 16, 2023

Great! Would it be possible to make a plugin for Beckhoff ADS interface the similar way?

@srebhan
Copy link
Contributor Author

srebhan commented Nov 16, 2023

@St3f1n please add a feature-request and, if possible, contribute a pull-request. You might use an existing Golang library e.g. https://github.com/gotwincat/twincat...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants