Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.fibaro): Support HC3 device types #13754

Merged
merged 5 commits into from
Aug 28, 2023
Merged

feat(inputs.fibaro): Support HC3 device types #13754

merged 5 commits into from
Aug 28, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 11, 2023

fixes: #10128

@powersj powersj mentioned this pull request Aug 11, 2023
Closed
@powersj powersj changed the title feat(inputs.fibaro) Support HC3 device types feat(inputs.fibaro): Support HC3 device types Aug 11, 2023
@powersj powersj self-assigned this Aug 11, 2023
@powersj powersj added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 11, 2023
@powersj powersj assigned srebhan and unassigned powersj Aug 25, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 25, 2023
@powersj powersj marked this pull request as ready for review August 25, 2023 12:49
srebhan
srebhan reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments...

plugins/inputs/fibaro/fibaro_test.go Outdated Show resolved Hide resolved
plugins/inputs/fibaro/fibaro_test.go Outdated Show resolved Hide resolved
plugins/inputs/fibaro/hc3/types.go Outdated Show resolved Hide resolved
plugins/inputs/fibaro/hc3/parser.go Outdated Show resolved Hide resolved
plugins/inputs/fibaro/hc3/parser.go Outdated Show resolved Hide resolved
@powersj
post-review changes
e604d0d 
* test JSON in files
* use expected metrics
* unexport struct
* pre-allocated maps
@powersj
Copy link
Contributor Author

powersj commented Aug 28, 2023

Review changes pushed

srebhan
srebhan reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last thing...

plugins/inputs/fibaro/hc3/parser.go Outdated Show resolved Hide resolved
@powersj @srebhan
Update plugins/inputs/fibaro/hc3/parser.go
87b50df 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Aug 28, 2023
@srebhan srebhan merged commit ca2295e into influxdata:master Aug 28, 2023
23 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

inputs.Fibaro: support HC3 devices - plugin error line 74 defining "dead" as sting instead of bool property
2 participants
@powersj @srebhan