Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processors): Add processor to split a metric into multiple #13785

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 17, 2023

fixes: #13251

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor labels Aug 17, 2023
@powersj powersj marked this pull request as ready for review August 25, 2023 13:08
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 25, 2023
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan changed the title feat(processors.split): Split a metric into multiple feat(processors): Add split processor to split a metric into multiple Aug 28, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the processor @powersj. I have some comments especially on the documentation. Furhermore, I would prefer to name the unit-test directories testcases instead of testdata as this is what we do for other plugins...

plugins/processors/split/sample.conf Outdated Show resolved Hide resolved
plugins/processors/split/sample.conf Outdated Show resolved Hide resolved
plugins/processors/split/README.md Outdated Show resolved Hide resolved
plugins/processors/split/split.go Outdated Show resolved Hide resolved
plugins/processors/split/split.go Outdated Show resolved Hide resolved
plugins/processors/split/split.go Outdated Show resolved Hide resolved
@powersj
Copy link
Contributor Author

powersj commented Aug 29, 2023

ok - updates made! Let me know if the readme has enough warnings of if you think they should be bigger more bold?

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments regarding the README warnings...

plugins/processors/split/README.md Outdated Show resolved Hide resolved
plugins/processors/split/README.md Outdated Show resolved Hide resolved
powersj and others added 2 commits August 29, 2023 08:19
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@srebhan srebhan changed the title feat(processors): Add split processor to split a metric into multiple feat(processors): Add processor to split a metric into multiple Aug 29, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan merged commit dec4a90 into influxdata:master Aug 29, 2023
21 of 22 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate multiple metrics out of a single CSV file
2 participants