Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Add plugins subcommand to list available and deprecated #13787

Merged
merged 3 commits into from
Aug 29, 2023
Merged

feat(cli): Add plugins subcommand to list available and deprecated #13787

merged 3 commits into from
Aug 29, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 17, 2023

fixes: #11739

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 17, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 25, 2023
@powersj powersj marked this pull request as ready for review August 25, 2023 13:08
srebhan
srebhan reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas to save lines...

cmd/telegraf/cmd_plugins.go Outdated Show resolved Hide resolved
cmd/telegraf/cmd_plugins.go Outdated Show resolved Hide resolved
@powersj
Copy link
Contributor Author

powersj commented Aug 29, 2023

Thanks for the suggestions. I have updated the PR to use the single generic function, this looks really nice. I did keep the existing sprintf to avoid having a missing newline at the end. Thoughts?

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Thanks @powersj!

@srebhan srebhan merged commit 1e42262 into influxdata:master Aug 29, 2023
23 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

Add new command to list deprecation and plugins
2 participants
@powersj @srebhan