fix(metricpass): Remove python logic compatibility

[powersj]

fixes: #13790

[knollet]

this is the old affected version.

me@host:~/filter-bug$ telegraf -config filter-bug.conf -test
[...]
> bugreport,host=host,this=shouldn't\ !\ be\ modified and="is modified" 1692367811000000000
> bugreport,host=host,this=should\ not\ pass\ unmodified but="does pass unmodified" 1692367811000000000

this is the fix-artefact:

me@host:~/filter-bug$ bugfix/telegraf-1.28.0/usr/bin/telegraf -config filter-bug.conf -test
[...]
> bugreport,host=host,this=shouldn't\ !\ be\ modified and="is not modified" 1692367801000000000
> bugreport,host=host,this=should\ not\ pass\ unmodified but="is modified" 1692367801000000000

this is the old affected version.

me@host:~/filter-bug$ telegraf -config filter-bug2.conf -test
2023-08-18T14:14:46Z I! Loading config: filter-bug2.conf
2023-08-18T14:14:46Z E! error loading config file filter-bug2.conf: error parsing regex, ERROR: <input>:1:6: Syntax error: no viable alternative at input '.&&'
 | tags.&& == 'the name of this tag is &&'
 | .....^
ERROR: <input>:1:9: Syntax error: extraneous input '==' expecting {'[', '{', '(', '.', '-', '!', 'true', 'false', 'null', NUM_FLOAT, NUM_INT, NUM_UINT, STRING, BYTES, IDENTIFIER}
 | tags.&& == 'the name of this tag is &&'
 | ........^

this is the fix-artefact:

me@host:~/filter-bug$ bugfix/telegraf-1.28.0/usr/bin/telegraf -config filter-bug2.conf -test
[...]
> bugreport,&&=the\ name\ of\ this\ tag\ is\ &&,and=now\ for\ something\ completely\ different,host=host the="larch" 1692368092000000000

Looks good to me

[srebhan]

This is a breaking change and should be declared as such in the Changelog! Please also note that this was an explicit request by Dave back when I added this.

This being said, I'm fine with removing this as we can get rid of another regex pitfall and will approve when the breaking change is documented in the Changelog.

[powersj]

PR updated with change log entry!

This is a breaking change and should be declared as such in the Changelog! Please also note that this was an explicit request by Dave back when I added this.

Ah ok thanks for the history

[srebhan]

Thanks for taking care of this @powersj!

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz