Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.internal): Add Go metric collection option #13793

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 18, 2023

This allows users to set an option to collect the official runtime go metrics via the new interface introduced in Go 1.16. This is hidden behind an option due to the additional values that do overlap with the existing memstat option.

Sanitizes the names as such:

-- /cpu/classes/gc/mark/assist:cpu-seconds
++ cpu_classes_gc_mark_assist_cpu_seconds

fixes: #8645

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 18, 2023
@telegraf-tiger
Copy link
Contributor

@powersj powersj self-assigned this Aug 25, 2023
This allows users to set an option to collect the official runtime go
metrics via the new interface introduced in Go 1.16. This is hidden
behind an option due to the additional values that do overlap with the
existing memstat option.

fixes: influxdata#13781
@powersj powersj marked this pull request as ready for review August 29, 2023 14:03
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 29, 2023
@powersj powersj assigned srebhan and unassigned powersj Aug 29, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan merged commit d4a00dd into influxdata:master Aug 29, 2023
23 of 24 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include metrics from golang's new runtime/metrics package in telegraf's internal plugin
2 participants