Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(inputs.vsphere): fix config name typo in example #13907

Merged
merged 1 commit into from
Sep 12, 2023
Merged

docs(inputs.vsphere): fix config name typo in example #13907

merged 1 commit into from
Sep 12, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 12, 2023 •
edited

fixes: #13905

@telegraf-tiger telegraf-tiger bot added area/vsphere docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 12, 2023
@powersj powersj mentioned this pull request Sep 12, 2023
Closed
@Hipska
Copy link
Contributor

Hipska commented Sep 12, 2023

Not sure if this is the good approach. The name was resourcepool_ in previous versions of telegraf (<1.28) So it is more like a regression/breaking change..

@powersj
Copy link
Contributor Author

powersj commented Sep 12, 2023 •
edited

Can you please point out which PR changed the name? The sample config today already shows resource_pool....

This was not in the sample config till a 4 months ago when I added powersj@7436575

@Hipska
Copy link
Contributor

Hipska commented Sep 12, 2023

I thought #13720 but now you get me thinking..

@powersj
Copy link
Contributor Author

powersj commented Sep 12, 2023

What I think the user is seeing is the following:

  1. There is a typo in the README with the wrong name
  2. The user used that typo in their config, which does not match the sample config
  3. feat(inputs.vsphere): Support explicit proxy setting #13720 introduced the type annotations, which will make start up more strict
  4. The user now sees an issue because of the typo in their config

The user needs to fix the config option in their config and we need to remove the typo.

@powersj powersj merged commit 6832e6c into influxdata:master Sep 12, 2023
24 checks passed
@powersj powersj deleted the fix/13905 branch September 12, 2023 14:30
@powersj powersj added this to the v1.28.1 milestone Sep 12, 2023
powersj added a commit that referenced this pull request Sep 12, 2023
@powersj
docs(inputs.vsphere): fix config name typo in example (#13907)
b311647 
(cherry picked from commit 6832e6c)
@chenrui333 chenrui333 mentioned this pull request Sep 12, 2023
Merged
@powersj powersj restored the fix/13905 branch March 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/vsphere docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Milestone
v1.28.1
Development

Successfully merging this pull request may close these issues.

Config Variable and Docu are Different : resource_pool_metric_exclude
2 participants
@powersj @Hipska