Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.postgresql_extensible): Restore outputaddress behavior #13972

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 21, 2023

fixes: #13965

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 21, 2023
@powersj powersj marked this pull request as draft September 21, 2023 14:34
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 22, 2023
@powersj powersj marked this pull request as ready for review September 22, 2023 13:50
@srebhan
Copy link
Contributor

srebhan commented Sep 26, 2023

@powersj this basically reverts #13602 but only for postgres_extensible if I'm not missing anything. However, I think that is not necessary. The issue here is the additional outputaddress setting which should not be taken into account then determining the database name. Instead you should either check if the output-address is set and use tagAddress as you do in this PR and otherwise do what is in the code now.

What do you think? Furthermore I would expect the same issue to happen in the other plugins touched by #13602...

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just beautiful @powersj!

@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit ebb20bf into influxdata:master Sep 26, 2023
23 checks passed
@powersj powersj deleted the fix/13965 branch September 26, 2023 14:19
@github-actions github-actions bot added this to the v1.28.2 milestone Sep 26, 2023
powersj added a commit that referenced this pull request Oct 2, 2023
@powersj powersj restored the fix/13965 branch March 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
2 participants