Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs.stackdriver): Do not shallow copy map #14009

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix(outputs.stackdriver): Do not shallow copy map #14009

merged 1 commit into from
Sep 27, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 27, 2023

This does not shallow copy the resource label map and instead makes a deep copy of the values. This was causing additional metrics to end up with all the same resource labels, rather than their unique set.

fixes: #13911

@powersj
fix(outputs.stackdriver): Do not shallow copy map
9270e88 
This does not shallow copy the resource label map and instead makes a
deep copy of the values. This was causing additional metrics to end up
with all the same resource labels, rather than their unique set.

fixes: influxdata#13911
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Sep 27, 2023
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.19 % for linux amd64 (new size: 202.0 MB, nightly size 197.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj mentioned this pull request Sep 27, 2023
Closed
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 27, 2023
srebhan
srebhan approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj, especially for the unit-test!

@srebhan srebhan merged commit 637b8f8 into influxdata:master Sep 27, 2023
23 checks passed
@github-actions github-actions bot added this to the v1.28.2 milestone Sep 27, 2023
powersj added a commit that referenced this pull request Oct 2, 2023
@powersj
fix(outputs.stackdriver): Do not shallow copy map (#14009)
f98db69 
(cherry picked from commit 637b8f8)
@chenrui333 chenrui333 mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.2
Development

Successfully merging this pull request may close these issues.

Outputs.Stackdriver tags_as_resource_labels config option doesn't appear to be working as expected
2 participants
@powersj @srebhan