Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.mqtt): Reference correct password variable #14041

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

nexeck
Copy link
Contributor

@nexeck nexeck commented Oct 3, 2023

For me, connecting to MQTT with username/password and mqttv5 stopped working.
Not sure, but shouldn't it be cfg.Password instead of the config.Password Type?

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 3, 2023

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 3, 2023
@nexeck
Copy link
Contributor Author

nexeck commented Oct 3, 2023

!signed-cla

@nexeck nexeck closed this Oct 3, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 3, 2023

@nexeck nexeck reopened this Oct 3, 2023
@nexeck
Copy link
Contributor Author

nexeck commented Oct 3, 2023

Telegraf 1.25.3 works for me with mqtt output, mqtt v5 and EMQX as an MQTT Server.
Beginning with telegraf 1.26.0 EMQX isn't accepting any connection from telegraf anymore.
reason: {shutdown,bad_username_or_password}

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This in fact does look like a regression, but from a commit last week, long after v1.26.0.

TIL that there is a Password variable in the config module lol

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 3, 2023
@powersj powersj changed the title fix: use password for mqtt from cfg.Password fix(inputs.mqtt): Reference correct password variable Oct 3, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O M G! Thanks for catching this @nexeck!

@srebhan srebhan added area/mqtt plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 4, 2023
@srebhan srebhan merged commit aa2990d into influxdata:master Oct 4, 2023
28 checks passed
@github-actions github-actions bot added this to the v1.28.3 milestone Oct 4, 2023
powersj pushed a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mqtt fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants