Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.s7comm): Allow PDU-size to be set as config option #14045

Merged
merged 4 commits into from
Oct 4, 2023
Merged

fix(inputs.s7comm): Allow PDU-size to be set as config option #14045

merged 4 commits into from
Oct 4, 2023

Conversation

phagemann
Copy link
Contributor

@phagemann phagemann commented Oct 3, 2023 •
edited

resolves #14042

Moved const maxRequestsPerBatch to be set from config file by keyword pdu_size

@phagemann
fix(inputs.s7comm)
a98a0a6 
Moved const maxRequestsPerBatch to be set from config file
@phagemann
fix(inputs.s7comm)
83c5b0f 
Updated README.md
@phagemann phagemann changed the title fix(inputs.s7comm) allow pdu-size to be set from config file fix(inputs.s7comm): allow pdu-size to be set from config file Oct 3, 2023
@phagemann
fix(inputs.s7comm)
8f870ff 
Adjusted bit parsing (influxdata#14043)
powersj
powersj reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to put up a PR. One question inline, otherwise I'll defer to Sven on this one.

@phagemann
fix(inputs.s7comm)
4c0cd88 
Removed unrelated changes
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 3, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 3, 2023
srebhan
srebhan approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @phagemann!

@srebhan srebhan added area/iot New plugins or features relating to IoT monitoring plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Oct 4, 2023
@srebhan srebhan changed the title fix(inputs.s7comm): allow pdu-size to be set from config file fix(inputs.s7comm): Allow PDU-size to be set as config option Oct 4, 2023
@srebhan srebhan merged commit 30bbf4f into influxdata:master Oct 4, 2023
24 checks passed
@github-actions github-actions bot added this to the v1.28.3 milestone Oct 4, 2023
@phagemann
Copy link
Contributor Author

Thanks for your great work maintaining this project! =)

powersj pushed a commit that referenced this pull request Oct 23, 2023
@phagemann @powersj
fix(inputs.s7comm): Allow PDU-size to be set as config option (#14045)
af21bad 
(cherry picked from commit 30bbf4f)
@p-linnane p-linnane mentioned this pull request Oct 23, 2023
Merged
@GitTurboy GitTurboy mentioned this pull request Nov 10, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/iot New plugins or features relating to IoT monitoring fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.3
Development

Successfully merging this pull request may close these issues.

inputs.s7comm PDU size exceeded
3 participants
@phagemann @powersj @srebhan