fix(inputs.jenkins): Filter after searching sub-folders #14105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
Currently, the Jenkins plugin will apply the user filter to directory names immediately. If the directory does not match the filter it would toss the folder. This prevents traversing into the folder itself where a user might want a job inside the folder. This change will move the filtering operation to occur after we kick off directory traversal. The changes to the tests were necessary since we never went into the folders correctly. The test results are the same, the changes are to the response our mock jenkins server provides. fixes: influxdata#14054
powersj
changed the title
powersj
added
the
ready for final review
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
athornton
pushed a commit
to lsst-sqre/telegraf
that referenced
this pull request
Oct 19, 2023
powersj
added a commit
that referenced
this pull request
Oct 23, 2023
(cherry picked from commit 3fbe624)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Jenkins plugin will apply the user filter to directory
names immediately. If the directory does not match the filter it would
toss the folder. This prevents traversing into the folder itself where a
user might want a job inside the folder.
This change will move the filtering operation to occur after we kick off
directory traversal. The changes to the tests were necessary since we
never went into the folders correctly. The test results are the same,
the changes are to the response our mock jenkins server provides.
fixes: #14054