Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.vault): Use http client to handle redirects correctly #14153

Merged
merged 5 commits into from
Oct 23, 2023
Merged

fix(inputs.vault): Use http client to handle redirects correctly #14153

merged 5 commits into from
Oct 23, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Oct 20, 2023

resolves #14138

This PR fixes handling of redirects from servers by switching the vault plugin to using http.Client instead of http.RoundTripper. While at it, we also use the plugins/common/http package for convenience adding more
nice features like proxy support...

Additionally to the functional change, the PR adds an integration test and a http-redirect test mimicking the issue in #14138.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 20, 2023
@srebhan srebhan mentioned this pull request Oct 20, 2023
Closed
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 23, 2023
@powersj powersj merged commit 56edee0 into influxdata:master Oct 23, 2023
23 checks passed
@github-actions github-actions bot added this to the v1.28.3 milestone Oct 23, 2023
powersj pushed a commit that referenced this pull request Oct 23, 2023
@srebhan @powersj
fix(inputs.vault): Use http client to handle redirects correctly (#14153
c6a91a7 
)

(cherry picked from commit 56edee0)
@p-linnane p-linnane mentioned this pull request Oct 23, 2023
Merged
powersj added a commit to powersj/telegraf that referenced this pull request Mar 28, 2024
@powersj
fix(inputs.prometheus): Remove duplicate response_timeout option
19728c5 
In influxdata#14153, the HTTP client config struct gained a response timeout
config option with TOML tags. This meant that there were two defined for
both Prometheus plugin and the HTTP client config struct. This removes
the one in Prometheus, which was used to set the one in the HTTP client
anyway.

fixes: influxdata#15076
This was referenced Mar 28, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.3
Development

Successfully merging this pull request may close these issues.

Plugin Vault: status 307 Temporary Redirect
2 participants
@srebhan @powersj