Outputs enhancement to require Description and SampleConfig functions #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
outputs-polish
branch
3 times, most recently
from
83082d9
to
acc27f6
Compare
| # password = "metricsmetricsmetricsmetrics" | ||
| # Tags can also be specified via a normal map, but only one form at a time: | ||
| [tags] | ||
| # dc = "us-east-1" } |
There was a problem hiding this comment.
I think that closing bracket } is out of place/not needed
|
@sparrc couple comments but nothing ground breaking :) thanks for adding this! |
sparrc
force-pushed
the
outputs-polish
branch
2 times, most recently
from
1046612
to
8afbad9
Compare
|
thanks @jipperinbham for the feedback 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jipperinbham please verify the
SampleConfg()andDescription()functions for thedatadogoutput, thanks!