Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.prometheus_client): Always default to TCP #14471

Merged
merged 2 commits into from Jan 4, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Dec 18, 2023

Summary

#14108 introduced the ability to listen on vsock. In that PR, telegraf parses the URL and determines which function to call based on the scheme of the URL. This function was missing what to do when there is no scheme, breaking backwards compatibility. Additionally, if using a URL like mgt:3839, scheme will report as mgt. To maintain backwards compatibility we should always try TCP.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14468

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Dec 18, 2023
@powersj powersj self-assigned this Dec 21, 2023
@powersj powersj changed the title fix(outputs.prometheus_client): Default empty scheme to TCP fix(outputs.prometheus_client): Always default to TCP Jan 2, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 2, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 4.07 % for linux amd64 (new size: 219.8 MB, nightly size 211.3 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 3, 2024
@powersj powersj assigned srebhan and unassigned powersj Jan 3, 2024
@powersj powersj marked this pull request as ready for review January 3, 2024 14:02
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @powersj! Thanks!

@srebhan srebhan merged commit 9ec0894 into influxdata:master Jan 4, 2024
25 of 26 checks passed
@github-actions github-actions bot added this to the v1.29.2 milestone Jan 4, 2024
powersj added a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prometheus fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[outputs.prometheus_client] generates an error in 1.29.1 version
3 participants