Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.filecount): Respect symlink files with FollowSymLinks #14669

Merged
merged 1 commit into from Feb 6, 2024

Conversation

DStrand1
Copy link
Contributor

@DStrand1 DStrand1 commented Feb 1, 2024

Summary

godirwalk does not automatically filter out symlink files with its FollowSymbolicLinks config option. Changes to calling Fstat if needed to respect the settings, where before it would call Stat and automatically follow the link

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #13250

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 1, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 1, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.46 % for linux amd64 (new size: 224.7 MB, nightly size 221.5 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan self-assigned this Feb 6, 2024
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @DStrand1!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 6, 2024
@srebhan srebhan assigned powersj and unassigned srebhan Feb 6, 2024
@powersj powersj merged commit 1d513e6 into influxdata:master Feb 6, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.29.5 milestone Feb 6, 2024
@DStrand1 DStrand1 deleted the fix/13250 branch February 8, 2024 14:07
powersj pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filecount-Plugin - Don't follow File-Symlinks
3 participants