update gopsutil for FreeBSD disk time metrics #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results in adding the io_time metric to FreeBSD, and adjusts the read_time and write_time metrics to be in milliseconds like linux.
bitmori
pushed a commit
to bitmori/telegraf
that referenced
this pull request
Jul 23, 2016
Results in adding the io_time metric to FreeBSD, and adjusts the read_time and write_time metrics to be in milliseconds like linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted a patch upstream to gopsutil to fix some diskio time issues on FreeBSD: shirou/gopsutil#232
The issue was that the
read_timeandwrite_timemetrics on Linux were reported in milliseconds, but on FreeBSD they were in seconds. Theio_timemetric was also missing entirely. The upstream PR fixed both these issues.While the
io_timemight be considered a feature, the inconsistent time units between Linux & FreeBSD I would consider a bug, and so I have classified this as a bug fix in the CHANGELOG.This is all the upstream changes that will be pulled in: shirou/gopsutil@586bb69...ee66bc5
Required for all PRs: