Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.161.1 to 1.162.1 #15448

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 3, 2024

Bumps github.com/aws/aws-sdk-go-v2/service/ec2 from 1.161.1 to 1.162.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 3, 2024
@telegraf-tiger telegraf-tiger bot added the chore label Jun 3, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/ec2-1.162.1 branch 2 times, most recently from 098e919 to 60c9c8f Compare June 4, 2024 08:35
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 4, 2024
@powersj
Copy link
Contributor

powersj commented Jun 4, 2024

@srebhan - you approved, but did you have a commit to push to resolve the deprecation messages? Looking at https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/endpoints/ seems to show how to convert our aws.EndpointResolveWithOptionFunc and aws.Endpoint?

Looks like we need to make updates to at least the timestream and cloudwatch_logs outputs.

@powersj powersj removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 4, 2024
dependabot bot and others added 2 commits June 7, 2024 08:34
Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.161.1 to 1.162.1.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.161.1...service/ec2/v1.162.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@powersj powersj force-pushed the dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/ec2-1.162.1 branch from 60c9c8f to 8dd65ad Compare June 7, 2024 15:31
@powersj
Copy link
Contributor

powersj commented Jun 7, 2024

It looks like the primary suggestion is to pass the custom endpoint to the service config directly. Basicaly we use a mutalable endpoint since we don't set immutable to true which means this applies:

Returning an Endpoint with HostnameImmutable set to false is roughly equivalent to setting BaseEndpoint to the originally returned URL from v1 and leaving EndpointResolverV2 as the default.

I tested these updates with cloudwatch_logs using a config like:

[[outputs.cloudwatch_logs]]
  region = "us-east-1"
  log_group = "powersj-telegraf-test"
  log_stream = "tag:host"
  log_data_metric_name  = "metric"
  log_data_source  = "field:value"

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 7, 2024

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 10, 2024
@powersj powersj removed their assignment Jun 10, 2024
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan removed their assignment Jun 10, 2024
@DStrand1 DStrand1 merged commit 05ba495 into master Jun 10, 2024
28 checks passed
@DStrand1 DStrand1 deleted the dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/ec2-1.162.1 branch June 10, 2024 18:16
@github-actions github-actions bot added this to the v1.31.1 milestone Jun 10, 2024
srebhan pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants