Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update golangci-lint from v1.58.0 to v1.59.0 #15473

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jun 6, 2024

Summary

We certainly should not be using 777 permissions anywhere, the directory monitor change is the only possible regression here. The others are all in tests.

Checklist

  • No AI generated code was used in this PR

@telegraf-tiger telegraf-tiger bot added the chore label Jun 6, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 6, 2024

@srebhan srebhan added dependencies Pull requests that update a dependency file linter labels Jun 7, 2024
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj! One comment but probably not for this PR, so I approved.

plugins/inputs/linux_cpu/linux_cpu_test.go Show resolved Hide resolved
@powersj powersj assigned DStrand1 and unassigned powersj Jun 7, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 7, 2024
@DStrand1 DStrand1 merged commit 5c3aa87 into influxdata:master Jun 7, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants