Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.http_response): fix the use of hostnames + interface #15596

Closed
wants to merge 1 commit into from
Closed

fix(inputs.http_response): fix the use of hostnames + interface #15596

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Jul 6, 2024 •
edited
Loading

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 6, 2024
@Mic92 Mic92 force-pushed the fix-http-response branch 2 times, most recently from 00d77be to fa18413 Compare July 6, 2024 06:33
@Mic92 Mic92 marked this pull request as ready for review July 6, 2024 06:37
@Mic92 Mic92 marked this pull request as draft July 6, 2024 06:41
@Mic92 Mic92 marked this pull request as ready for review July 6, 2024 06:46
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 6, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

powersj
powersj reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mic92 - can you please file an issue with some background as to why this change needs to occur and justify the TODO as well please?

plugins/inputs/http_response/http_response.go
Comment on lines +106 to +110
// TODO: Resolving the address to bind is better done at gather time rather than setup time.
// Then we could ask the system resolver to resolve the address with the scope of the interface
// and it would also gives us the correct address for the interface to use.
// Unfortunally the portable libc interfaces does not allow us to do that.
// macOS, systemd-resolved on Linux and Windows have different ways to do that.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do not like TODOs in code like this. This also seems outside the scope of the issue at hand?

@powersj powersj added the waiting for response waiting for response from contributor label Jul 8, 2024
@telegraf-tiger
Copy link
Contributor

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!

@telegraf-tiger telegraf-tiger bot closed this Jul 23, 2024
@powersj
Copy link
Contributor

powersj commented Jul 24, 2024

Hi,

Would be happy to circle around to this PR once you file an issue and remove the TODO. Thanks!

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jul 24, 2024
@Mic92
Copy link
Contributor Author

Mic92 commented Jul 24, 2024

2 weeks is a bit short for a timeout, i.e. if you go on holiday.

@Mic92 Mic92 mentioned this pull request Jul 24, 2024
Closed
1 task
@powersj
Copy link
Contributor

powersj commented Jul 24, 2024

2 weeks is a bit short for a timeout, i.e. if you go on holiday.

Which is why we are perfectly fine re-opening this PR if you came back around to it or if you communicated you are out ;)

@Mic92
Copy link
Contributor Author

Mic92 commented Jul 25, 2024

I don't have permissions to re-open a PR and all previous reviews are missing in the new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj left review comments

Assignees
No one assigned
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @powersj