Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(inputs.opcua_listener): Enhance explanation of subscription interval #15598

Merged
merged 2 commits into from
Jul 8, 2024
Merged

docs(inputs.opcua_listener): Enhance explanation of subscription interval #15598

merged 2 commits into from
Jul 8, 2024

Conversation

jbuitmann
Copy link
Contributor

Summary

The rationale behind this change is to clarify that setting the subscription_interval does not guarantee the server will update at this rate. The server might reject the interval if it cannot meet the required update rate due to hardware or software limitations. These notes aim to prevent misunderstandings and guide users to refer to their server's documentation, ensuring correct system configuration.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #

feat: enhance explanation in opc ua listener in conf
501965c 
MINOR: Improved the explanation of how the subscription_interval works for better clarity in usage.
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 7, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 8, 2024
@srebhan srebhan changed the title feat: enhance explanation in opc ua listener in conf docs(inputs.opcua_listener): Enhance explanation of subscription interval Jul 8, 2024
@telegraf-tiger telegraf-tiger bot added docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 8, 2024
srebhan
srebhan approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Julian-Buitmann!

@srebhan srebhan added area/opcua and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jul 8, 2024
@srebhan srebhan merged commit 7fedef8 into influxdata:master Jul 8, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.31.2 milestone Jul 8, 2024
powersj pushed a commit that referenced this pull request Jul 22, 2024
@jbuitmann @powersj
docs(inputs.opcua_listener): Enhance explanation of subscription inte…
f4e75e6 
…rval (#15598)

Co-authored-by: jbuitman <julian.buitmann@hs-osnabrueck.de>
Co-authored-by: Josh Powers <powersj@fastmail.com>
(cherry picked from commit 7fedef8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

@DStrand1 DStrand1

Labels
area/opcua docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbuitmann @powersj @srebhan @DStrand1