Add device name as a tag in disk stats #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… report device name (minus /dev/) as a tag in disk stats
|
You might want to look at #1453. Currently it only affects diskio inputs. But it should be easy to include it on the disk inputs as well. |
…add_device_name_to_disk_stats
…rom disk usage method calls
|
@sparrc Any guidance? If this isn't going to make it, we need to think about how our backend is going to handle mount points without sending some really odd data. |
|
thanks for reminding, we'll try to get it ready for 1.2 |
sparrc
approved these changes
Dec 5, 2016
…add_device_name_to_disk_stats
… to report disk stats)
2 tasks
bcaudesaygues
pushed a commit
to viareport/telegraf
that referenced
this pull request
Feb 6, 2017
* return partition stat alongside disk stat from disk usage method, and report device name (minus /dev/) as a tag in disk stats * update system/disk tests to include new partition stat return value from disk usage method calls * update changelog for influxdata#1807 (use device name instead of path to report disk stats)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
This returns device name as a tag (alongside mount point), and removes /dev/ from the device name for ease of reading.