snmp: return error on unknown conversion type #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also wondering if we should capture panics coming from I find it rather odd that a panic is thrown instead of returning an error. I know the current signature of the call doesn't return error, but maybe it should. |
|
Doesn't seem like it should be panicking, but we are using a fairly old changeset of the influxdb repo, and the latest might have a different behavior. I'll be updating the dependency in #1777 |
|
Doesn't look like the current code is any different: https://github.com/influxdata/influxdb/blob/master/models/points.go#L1769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Since the influxdb models marshaller panics on byte slices (when not a valid line-protocol value), we should throw an error instead of passing through the value unchanged.
I didn't update the changelog or anything as this isn't really a bug fix or enhancement. Unless people have misconfigured telegraf, there should be no behavior change.
closes #1852