Fix conditional test against useradd so it's compatible with Dash #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it's better to use "-eq 0", then? |
The test to see which version of `useradd` is installed uses 'bashisms' that fail on Ubuntu due to the fact that `/bin/sh` is symlinked to Dash, causing the telegraf account to be created without the `--system` option ever being passed. This change amends the syntax so that it's POSIX-compatible and more portable as a result.
yankcrime
force-pushed
the
postinst_dash_compat_fix
branch
from
ee52cbc
to
cd7468f
Compare
|
@ekini Good point, thanks! |
|
this looks good, thank you @yankcrime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test to see which version of
useraddis installed uses 'bashisms' that fail on Ubuntu due to the fact that/bin/shis symlinked to Dash, causing the telegraf account to be created without the--systemoption ever being passed.This change amends the syntax so that it's POSIX-compatible and more portable as a result. Fixes #231.