Increment gather_errors for all errors emitted by inputs #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmopetrich
commented
Jan 29, 2017
| @@ -157,7 +157,7 @@ func gatherWithTimeout( | |||
| select { | |||
| case err := <-done: | |||
| if err != nil { | |||
| log.Printf("E! ERROR in input [%s]: %s", input.Name(), err) | |||
| acc.AddError(err) | |||
| } | |||
| return | |||
| case <-ticker.C: | |||
There was a problem hiding this comment.
I wasn't sure whether it made sense to invoke AddError on "took longer than collection interval" errors.
|
this certainly seems like a good idea to me, what do you think @phemmer? we should probably document that plugins should never call |
|
@cosmopetrich feel free to update the changelog |
|
I'm for it. |
|
done |
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md updated (if adding a new plugin)I'm not sure if the change made here is the correct way to go about this, but I figured a PR would be better way to start a discussion than an issue or groups post.
Most Telegraf input plugins don't currently seem to provide a metric that can be used to determine if the gather operation is running successfully. For example, the prometheus input plugin logs an error if given a target address that returns HTTP 401, but won't return any metrics. That makes it difficult to tell whether a particular Prometheus client is "up".
I'd thought of deploying http_response inputs alongside httpjson/prometheus inputs, but that's a fair bit of extra configuration and doesn't handle endpoints that return 200 but with invalid data, etc. Adding a new metric to the prometheus input was another option but it looks like some other plugins behave similarly and it would be nice to have a more generic solution.
Telegraf 1.2 added the internal plugin, which exposes an
internal_agent_gather_errorsmetric. That seems like a reasonable thing to monitor, however as far as I can tell it's only incremented by the SNMP plugin. This PR aims to increment the metric whenever any input emits an error. This won't catch all errors, as quite a number of plugins handle and log errors internally. I can update those too, but that's probably best in a separate PR.