Expose kafka client id #4418
Merged
Expose kafka client id #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
feat
| @@ -17,6 +17,7 @@ import ( | |||
|
|
|||
| type Kafka struct { | |||
| ConsumerGroup string | |||
| ClientId string `toml:"client_id"` | |||
There was a problem hiding this comment.
Call the variable ClientID
| @@ -22,6 +22,9 @@ and use the old zookeeper connection method. | |||
| ## Offset (must be either "oldest" or "newest") | |||
| offset = "oldest" | |||
|
|
|||
| ## Optional client id | |||
| # client_id = "my_client" | |||
There was a problem hiding this comment.
Let's have the example ID be Telegraf? Perhaps this should be the default instead of "sarama"?
There was a problem hiding this comment.
The default value of sarama is set by the underlying implementation used by both kafka plugins. I can add the logic to set the id to "Telegraf" when a value is not supplied.
|
ATM I am running the test on a Mac v10.13.2 (17C88) |
|
Thank you! |
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The team running the Kafka I was using required that I set the client id for reads and writes. For reference, the default client id is "sarama"
Required for all PRs:
I ran "make lint" and "make test", the latter showed failures for unrelated files. (outputs/socket_writer, outputs/influxdb, inputs/syslog, inputs/socket_listener, inputs/ping, inputs/http_response, inputs/fluentd)