Add scraping for Prometheus endpoint in Kubernetes #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to add Prometheus annotations in services in Kubernetes, and have telegraf scan for them and add them to the list of endpoints to collect metrics from
glinton
added
feat
3 tasks
|
Thank you so much for taking this over. I've been swamped doing other stuff. |
gianarb
approved these changes
Oct 30, 2018
danielnelson
suggested changes
Oct 30, 2018
danielnelson
reviewed
Nov 2, 2018
danielnelson
reviewed
Nov 2, 2018
danielnelson
suggested changes
Nov 5, 2018
| } | ||
|
|
||
| p.wg = sync.WaitGroup{} | ||
| in := make(chan payload) |
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| break |
There was a problem hiding this comment.
Need to use a return or we won't exit the for loop
There was a problem hiding this comment.
should we remove the err checking logic on the p.watch as well, since it doesn't effectively do anything for us?
There was a problem hiding this comment.
I would probably move the logging from line 84 up to this function, and just return err in the watch function. I see that there is both an error and debug level message in watch, but since they both terminate the watch function I think they should both be error level.
danielnelson
approved these changes
Nov 5, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up from, replaces, and closes #3901