Add Graphite output #494
Closed
Add Graphite output #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With HTTP JSON or Elasticsearch, one can also process values nested in arrays.
| for field_name, value := range point.Fields() { | ||
| // Convert value | ||
| var value_str string | ||
| switch value := value.(type) { |
There was a problem hiding this comment.
You don't need to do this type switch. Just do:
value_str := fmt.Sprintf("%#v", value)
|
looks good, I made a few comments, you can also just have this PR merge back into master now. Thanks for dealing with all the recent changes! |
While at it also add a missing dependency on lsof required by the netstat plugin. closes influxdata#512
Open
…ition in post-install. closes influxdata#526 closes influxdata#525
also mentioned name_override and name_prefix on top of name_suffix
…-v0.10 interval options should have string value
|
@sparrc Hello ! I fixed all your comments and rebased on master. |
|
Awesome, thanks a bunch @titilambert! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR of #451 rebased on 0.3.0