Refactor value verification to manage bools. #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings are still dropped, bools are set to 1 for true and 0 for false Solves: influxdata#5006
danielnelson
suggested changes
Nov 19, 2018
| case bool: | ||
| if field.Value == bool(true) { | ||
| // Store 1 for a "true" value | ||
| field.Value = 1 |
There was a problem hiding this comment.
Can you change this to copy to a local? I'm planning to change around FieldList() to prevent modification this way, it will give more predictable behavior during retries and harder to use the type incorrectly.
Might be easiest to rename verifyValue and have it return a value + bool so we don't have to switch twice:
func convertValue(v interface{}) (interface{}, bool)
There was a problem hiding this comment.
went back to having it called verifyValue() but I believe I implemented it in a fashion compatible with your request.
There was a problem hiding this comment.
(I don't know what the protocol is for who should resolve the conversation)
Move value type verification and modification back to a function store value modifications in a local. Remove a bit of duplicate work.
danielnelson
approved these changes
Nov 19, 2018
glinton
approved these changes
Nov 20, 2018
danielnelson
pushed a commit
that referenced
this pull request
Nov 22, 2018
(cherry picked from commit 85ee354)
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings are still dropped, bools are set to 1 for true and 0 for false
closes: #5006
Required for all PRs: