Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set windows docker client version to lowest supported #5302

Closed
wants to merge 1 commit into from

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Jan 17, 2019

As pointed out in #4666, the lowest docker version windows supports is 1.24. NegotiateAPIVersion isn't an option because it only downgrades the client to the server version, since the client in telegraf is set lower than docker will ever report, it does nothing.

Ideally we'd quit supporting EOL docker versions that require older docker clients and go back to using 1.24 for all distributions. Would revert change made in #4434 to support deprecated versions of docker 馃槼.

@danielnelson
Copy link
Contributor

I don't think this fix can work, since docker is often collecting over the network. For example, you may be collecting from Windows Docker over the network from Linux.

@danielnelson danielnelson deleted the bugfix/4666 branch December 5, 2019 19:33
@olljanat
Copy link
Contributor

@glinton I think that if you add another check that if host value starts with npipe: then it is bullet proof as that is possible only if Telegraf is running on Windows and it is connecting to local Docker installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants