Don't overwrite forecast points #5930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regel
approved these changes
May 31, 2019
|
I've never seen the sun here :P |
glinton
approved these changes
May 31, 2019
| AppId string `toml:"app_id"` | ||
| CityId []string `toml:"city_id"` | ||
| Fetch []string `toml:"fetch"` | ||
| BaseUrl string `toml:"base_url"` |
There was a problem hiding this comment.
Almost in alphabetical order I see ;) not sure if it was intentional or not. (no change required, just pointing out)
There was a problem hiding this comment.
It's ordered like in the config file, so "required" stuff up top. And also mostly random.
| # response_timeout = "5s" | ||
|
|
||
| ## Preferred unit system for temperature and wind speed. Can be one of | ||
| ## "metric", "imperial", or "standard". |
There was a problem hiding this comment.
I do prefer this comment over the one in the readme if you were to make them match.
hwaastad
pushed a commit
to hwaastad/telegraf
that referenced
this pull request
Jun 13, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my usual post merge CHANGELOG/README additions for the openweathermap plugin, and also some review comments from today, but I also noticed an issue with the way we generated points to be overwritten that I missed during review. We won't be able to do it this way since most outputs are not idempotent, and its risky even with InfluxDB because the output order is not guaranteed.
I also added a few new tags/fields I'm interested in: city name, country, cloudiness (I live in SF after all), visibility, sunrise, sunset. Sometime soon I'd like to add a geohash @goller.
Switched the tests over to the testutil metrics.go functions, since I'm still planning to get rid of the acc.AssertBlah functions eventually. Ended up removing the timeout test because of how long it takes and also because it is potentially racy, will have to investigate if we can readd this safely but for now I'm not sure.
cc @regel
Required for all PRs: