Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disk host to fields #5951

Closed
wants to merge 1 commit into from
Closed

Add disk host to fields #5951

wants to merge 1 commit into from

Conversation

zombielinux
Copy link

Allow for easier monitoring of large disk deployments by allowing tag filtering based on originating host.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@zombielinux
Add disk host to fields
4e67792 
Allow for easier monitoring of large disk deployments by allowing tag filtering based on originating host.
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 5, 2019
@danielnelson danielnelson mentioned this pull request Jun 5, 2019
Merged
3 tasks
@danielnelson
Copy link
Contributor

I think we should skip modifying the Disk type and handle this all in the top hddtemp.go, we should also use the source tag to hold only the hostname portion of the address as this is something we are attempting to standardize on. It was a big easier for me to describe with a pull request, so I just put it in #5955, can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zombielinux @danielnelson