Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch output - Add support up to ES 7.x #6053

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Elasticsearch output - Add support up to ES 7.x #6053

merged 2 commits into from
Jul 1, 2019

Conversation

lpic10
Copy link
Contributor

@lpic10 lpic10 commented Jun 27, 2019

This PR adapts the index template to work on versions 6.x and 7.x while still supporting 5.x

Also it removes the mapping type on ES 7.x as mapping types are deprecated. Telegraf still sets the mapping type to "metrics" to keep backwards compatibility on previous ES versions.

Tested manually on versions 5.6, 6.0, 6.8 and 7.2

closes #5780
closes #4268

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@sureshsubramaniam
Copy link

Is there a possibility to add Elasticsearch output to send to Elasticsearch service in AWS where it may need to be signed before initiating the connection similar to running a AWS proxy

@glinton glinton added area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jun 27, 2019
@lpic10
Copy link
Contributor Author

lpic10 commented Jun 28, 2019

Is there a possibility to add Elasticsearch output to send to Elasticsearch service in AWS where it may need to be signed before initiating the connection similar to running a AWS proxy

Elasticsearch output uses Elastic client (https://github.com/olivere/elastic) and it seems to be possible with few changes: https://github.com/olivere/elastic/wiki/Using-with-AWS-Elasticsearch-Service

As I don't use AWS Elasticsearch myself it would be difficult for me to implement that correctly.
Anyway, I think you should open a new Feature Request.

@sureshsubramaniam
Copy link

Is there a possibility to add Elasticsearch output to send to Elasticsearch service in AWS where it may need to be signed before initiating the connection similar to running a AWS proxy

Elasticsearch output uses Elastic client (https://github.com/olivere/elastic) and it seems to be possible with few changes: https://github.com/olivere/elastic/wiki/Using-with-AWS-Elasticsearch-Service

As I don't use AWS Elasticsearch myself it would be difficult for me to implement that correctly.
Anyway, I think you should open a new Feature Request.

Thanks will look into the referenced Elastic client and create a raise a Feature request

@danielnelson danielnelson added this to the 1.12.0 milestone Jul 1, 2019
@danielnelson danielnelson merged commit 5bad2c3 into influxdata:master Jul 1, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@sjwang90 sjwang90 mentioned this pull request Nov 18, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch 7 default mapping deprecated and no longer supported Add support for elasticsearch 6 output
4 participants