aggregators: allow historical data in aggregators #6119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagollnick
reviewed
Jul 16, 2019
| @@ -1065,6 +1065,18 @@ func buildAggregator(name string, tbl *ast.Table) (*models.AggregatorConfig, err | |||
| } | |||
| } | |||
|
|
|||
| if node, ok := tbl.Fields["allow_historical"]; ok { | |||
There was a problem hiding this comment.
am I correctly inferring that this is internal to telegraf? would this work for all plugins?
There was a problem hiding this comment.
It would work for all aggregator type plugins. Which means it extends all existing aggregator plugins with added functionality, but because the default value is false, it does not have adverse affects to existing deployments.
|
I just merged #6049, it should be possible to use it to get this type of behavior just by setting the new |
|
Thanks @danielnelson your solution works for us 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1992
This PR adds a boolean config to aggregator plugins,
allow_historical, which overrides the default behavior of ignoring metrics outside the period of the plugin. This override is useful when aggregating old logs or metrics that are delayed beyond the period window.Required for all PRs: