Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tags to smart_attributes #6201

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Added tags to smart_attributes #6201

merged 3 commits into from
Aug 6, 2019

Conversation

marcv81
Copy link
Contributor

@marcv81 marcv81 commented Aug 4, 2019

Added the tags model, capacity, and enabled to smart_attributes. These tags were only available for smart_device. This makes queries more consistent across smart_device and smart_attributes.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@marcv81
Copy link
Contributor Author

marcv81 commented Aug 4, 2019

Some tests failed for reasons which are likely transient and unrelated to my changes. I am not sure how to restart the builds. Please advise?

@marcv81
Copy link
Contributor Author

marcv81 commented Aug 5, 2019

Amending without change and pushing again fixed it.

@danielnelson danielnelson added this to the 1.12.0 milestone Aug 6, 2019
@danielnelson danielnelson added area/smart feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Aug 6, 2019
@danielnelson danielnelson merged commit 1c1c41c into influxdata:master Aug 6, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/smart feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants