Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): add darwin (macOS) builds to the release #6259

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Conversation

goller
Copy link
Contributor

@goller goller commented Aug 14, 2019

Closes #4801

This will build a darwin tar.gz package for macOS. This allows people an easy way to download
releases from github directly.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Closes #4801

This will build a darwin tar.gz package for macOS.  This allows people an easy way to download
releases from github directly.
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@goller goller merged commit 71da67e into master Aug 14, 2019
@goller goller deleted the feat/darwin branch August 14, 2019 21:05
@goller goller added this to the 1.12.0 milestone Aug 14, 2019
@vldgeorgiev
Copy link

This will be very useful for easier deployment of the executable as part of another package.
However, I saw that some time ago those darwin builds were disabled because there was an issue with cross-compiling depencencies #1571.
Is that solved now, so plugins will work in the new darwin tar.gz releases?

@goller
Copy link
Contributor Author

goller commented Aug 27, 2019

ug, this is a bummer...

I'll dig in and see if we can figure what to do here.

bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
This will build a darwin tar.gz package for macOS.  This allows people an easy way to download releases from github directly.
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
This will build a darwin tar.gz package for macOS.  This allows people an easy way to download releases from github directly.
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
This will build a darwin tar.gz package for macOS.  This allows people an easy way to download releases from github directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a tar.gz release package for Darwin / MacOS with CGO
3 participants